Discussion:
[tw] Bug report: Creating New Journal Tiddler deletes existing Journal Tiddler
Add Reply
Michael Wiktowy
2017-10-10 14:58:42 UTC
Reply
Permalink
Raw Message
Greetings all,

Description:
There is an issue using the "Create a new journal tiddler" button when
there is an existing one of the same name. Rather then use one of the
existing name collision mechanisms (opening existing tiddler for editing,
appending an incremental index on to the tiddler name or putting a warning
banner that an existing tiddler exists with the same name), a new empty
tiddler is opened with the same name and if it is saved instead of
cancelled, the old existing journal is overwritten without warning.

Method to reproduce:
1) Create a journal entry.
2) Within the same time increment that would create another journal entry
of the same name (different depending on the "Title of new journal
tiddlers" format in settings), create a new one using the "Create a new
Journal Tiddler" button.
3) Save newly created tiddler.
4) Previous journal tiddler gets deleted without warning

Expected Results:
Step 2) should load the existing tiddler to edit , or
Step 3) should give a warning that an existing tiddler of the same name
exists either in the editing toolbar or an "Are you sure?"-type popup on
saving.

Thanks,
/Mike
--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+***@googlegroups.com.
To post to this group, send email to ***@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/d6e738d6-6bb9-45dd-9d95-8e3c4561b835%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Mat
2017-10-10 15:10:37 UTC
Reply
Permalink
Raw Message
Confirmed!
Definitely a bug.
Could you post this on github?

<:-)
Post by Michael Wiktowy
Greetings all,
There is an issue using the "Create a new journal tiddler" button when
there is an existing one of the same name. Rather then use one of the
existing name collision mechanisms (opening existing tiddler for editing,
appending an incremental index on to the tiddler name or putting a warning
banner that an existing tiddler exists with the same name), a new empty
tiddler is opened with the same name and if it is saved instead of
cancelled, the old existing journal is overwritten without warning.
1) Create a journal entry.
2) Within the same time increment that would create another journal entry
of the same name (different depending on the "Title of new journal
tiddlers" format in settings), create a new one using the "Create a new
Journal Tiddler" button.
3) Save newly created tiddler.
4) Previous journal tiddler gets deleted without warning
Step 2) should load the existing tiddler to edit , or
Step 3) should give a warning that an existing tiddler of the same name
exists either in the editing toolbar or an "Are you sure?"-type popup on
saving.
Thanks,
/Mike
--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+***@googlegroups.com.
To post to this group, send email to ***@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/905446a2-b4ce-479b-9500-7c47b10fb3a6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Rob Hoelz
2017-10-10 15:15:16 UTC
Reply
Permalink
Raw Message
It's already reported: https://github.com/Jermolene/TiddlyWiki5/issues/2845

Until a fix is released, you could just fix your $:/
core/ui/PageControls/new-journal.tid
<https://github.com/Jermolene/TiddlyWiki5/commit/ec0fa2f9322346ec405b90356de03c66ae30cc0d#diff-e68644c29044cf78dbb9b3ec6f30948e>

-Rob
Post by Mat
Confirmed!
Definitely a bug.
Could you post this on github?
<:-)
Post by Michael Wiktowy
Greetings all,
There is an issue using the "Create a new journal tiddler" button when
there is an existing one of the same name. Rather then use one of the
existing name collision mechanisms (opening existing tiddler for editing,
appending an incremental index on to the tiddler name or putting a warning
banner that an existing tiddler exists with the same name), a new empty
tiddler is opened with the same name and if it is saved instead of
cancelled, the old existing journal is overwritten without warning.
1) Create a journal entry.
2) Within the same time increment that would create another journal entry
of the same name (different depending on the "Title of new journal
tiddlers" format in settings), create a new one using the "Create a new
Journal Tiddler" button.
3) Save newly created tiddler.
4) Previous journal tiddler gets deleted without warning
Step 2) should load the existing tiddler to edit , or
Step 3) should give a warning that an existing tiddler of the same name
exists either in the editing toolbar or an "Are you sure?"-type popup on
saving.
Thanks,
/Mike
--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+***@googlegroups.com.
To post to this group, send email to ***@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/7bc21cb6-66ef-4ff5-869c-589002d6b2b9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Michael Wiktowy
2017-10-10 15:27:34 UTC
Reply
Permalink
Raw Message
Thanks. That matches my problem and, while a related problem from 2009
turned up in a google search, this didn't.
I didn't see the details of a new-journal.tid workaround in that thread and
am hesitant to start poking around in the system tiddlers. Knowing about
the problem makes it easy to work around. I just didn't want it catching
new users with data loss.

/Mike
Post by Rob Hoelz
https://github.com/Jermolene/TiddlyWiki5/issues/2845
Until a fix is released, you could just fix your $:/
core/ui/PageControls/new-journal.tid
<https://github.com/Jermolene/TiddlyWiki5/commit/ec0fa2f9322346ec405b90356de03c66ae30cc0d#diff-e68644c29044cf78dbb9b3ec6f30948e>
-Rob
Post by Mat
Confirmed!
Definitely a bug.
Could you post this on github?
<:-)
Post by Michael Wiktowy
Greetings all,
There is an issue using the "Create a new journal tiddler" button when
there is an existing one of the same name. Rather then use one of the
existing name collision mechanisms (opening existing tiddler for editing,
appending an incremental index on to the tiddler name or putting a warning
banner that an existing tiddler exists with the same name), a new empty
tiddler is opened with the same name and if it is saved instead of
cancelled, the old existing journal is overwritten without warning.
1) Create a journal entry.
2) Within the same time increment that would create another journal
entry of the same name (different depending on the "Title of new journal
tiddlers" format in settings), create a new one using the "Create a new
Journal Tiddler" button.
3) Save newly created tiddler.
4) Previous journal tiddler gets deleted without warning
Step 2) should load the existing tiddler to edit , or
Step 3) should give a warning that an existing tiddler of the same name
exists either in the editing toolbar or an "Are you sure?"-type popup on
saving.
Thanks,
/Mike
--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+***@googlegroups.com.
To post to this group, send email to ***@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/8e2fda45-6de0-4a04-a928-9dc6949f5647%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...